.NET: Remove sequential\concurrent workflow extensions #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies workflow extension methods and adds overloads for hosting extensions to accept IHostedAgentBuilder parameters. The changes eliminate the AddConcurrentWorkflow and AddSequentialWorkflow convenience methods in favor of explicit workflow configuration, while enabling callers to pass agent builders directly to mapping methods instead of repeating agent names.
Key changes:
- Removed
AddConcurrentWorkflowandAddSequentialWorkflowextension methods - Added
IHostedAgentBuilderoverloads toMapA2A,MapOpenAIChatCompletions, andMapOpenAIResponses - Updated sample code to use explicit workflow configuration and new builder-based mapping methods
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| HostApplicationBuilderWorkflowExtensionsTests.cs | Removed unit tests for deleted AddConcurrentWorkflow and AddSequentialWorkflow methods |
| HostApplicationBuilderWorkflowExtensions.cs | Deleted AddConcurrentWorkflow and AddSequentialWorkflow methods and removed unused System.Collections.Generic import |
| EndpointRouteBuilderExtensions.Responses.cs | Added IHostedAgentBuilder overloads for MapOpenAIResponses method |
| EndpointRouteBuilderExtensions.ChatCompletions.cs | Added IHostedAgentBuilder overload for MapOpenAIChatCompletions and changed return type to IEndpointConventionBuilder |
| EndpointRouteBuilderExtensions.cs | Added four new MapA2A overloads accepting IHostedAgentBuilder |
| Program.cs | Updated sample to use explicit workflow configuration and new builder-based mapping methods |
stephentoub
reviewed
Oct 27, 2025
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
stephentoub
approved these changes
Oct 30, 2025
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Looks ok to me, though for the builder stuff I defer to @ReubenBond
4 tasks
DeagleGross
had a problem deploying
to
integration
GitHub Actions
Error
DeagleGross
had a problem deploying
to
integration
GitHub Actions
Error
DeagleGross
changed the title
IHostedAgentBuilder overloads for workflows; simplify workflow extensions
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
* remove non-standard workflow extensions, create overloads for IHostedAgentBuilder * rework * rollback extensions in a2a
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
AddConcurrentWorkflowandAddSequentialWorkflowas per #1603 (comment)